SimulPiscator / AirSane

Publish SANE scanners to MacOS, Android, and Windows via Apple AirScan.
GNU General Public License v3.0
251 stars 26 forks source link

Fails to build on Manjaro #59

Closed Zabuza825 closed 3 years ago

Zabuza825 commented 3 years ago

This is an issue I encountered when trying to install this on Manjaro.

I always encountered the following error when trying to run the make command, as shown in the readme:

/home/username/AirSane/server/scanjob.cpp: In member function ‘void ScanJob::Private::init(const {anonymous}::ScanSettingsXml&, bool, const Options&)’:
/home/username/AirSane/server/scanjob.cpp:259:30: error: ‘numeric_limits’ is not a member of ‘std’
  259 |     mImagesToTransfer = std::numeric_limits<int>::max();
      |                              ^~~~~~~~~~~~~~
/home/username/AirSane/server/scanjob.cpp:259:45: error: expected primary-expression before ‘int’
  259 |     mImagesToTransfer = std::numeric_limits<int>::max();
      |                                             ^~~
make[2]: *** [CMakeFiles/airsaned.dir/build.make:167: CMakeFiles/airsaned.dir/server/scanjob.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/airsaned.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

It seems this is an issue with scanjob.cpp in the server directory.

I was able to fix it by adding the following heads to that file:

#include <stdexcept>
#include <limits>

I know I "solved" this myself but I wanted to have this documented should someone wish to incorporate my fix into the main code.

SimulPiscator commented 3 years ago

Thanks! I added the #includes to the file in question.