search

SimulaVR / Simula

Linux VR Desktop
MIT License
2.94k stars 87 forks source link

Align modal windows with parent window #111

Closed danielfullmer closed 3 years ago

danielfullmer commented 4 years ago

Example here: simulavr

It would be better if modal windows were aligned with their parent window. If possible, this would help usability a lot. Applying a small offset from the parent window could be nice to experiment with for a 3D effect.

georgewsinger commented 4 years ago

This is a bug that only aflicts a few apps (chrome in particular, but not firefox). That said we're making progress on this issue:

image

...and it should be pushed by end of weekend (possibly EOD).

georgewsinger commented 4 years ago

:heavy_check_mark: Fixed in latest commit. To pull it run

git pull origin gdwlroots-xwayland
source ./utils/Helpers.sh && installSimula
./result/bin/simula

Let me know if you have any issues and I'll reopen the issue and fix them.

georgewsinger commented 4 years ago

@danielfullmer I recently pushed the dhall config to our repo. Per your request: it includes fields for setting default window resolution and scale. That said, I'm recently experiencing errors in NixOS. Specifically, chrome popups seem to no longer work for me (though they still work in non-NixOS). Did you ever confirm that chrome popups worked for you in NixOS?

danielfullmer commented 4 years ago

Yes, the chrome popups have been constrained to the original window for me in the past. I just verified it still has that behavior in the latest commit.

However, I just noticed this: chrome It might require zooming in, but notice how the selected option "History" creates another modal window to the right of it. But, most of this is cut off by the edge of the window.

georgewsinger commented 4 years ago

@danielfullmer We're working on a solution now to push popups that hang over window boundaries back inside the window. Once it's pushed I'll update this thread.

georgewsinger commented 4 years ago

@danielfullmer I just pushed a commit which crudely pushes subsurfaces into their parent window boundaries. There's still some subtle input and subsurface bugs to fix, but I think this is an overall improvement to the behavior. I'll keep you updated as we push more fixes on this front.