search

SimulaVR / Simula

Linux VR Desktop
MIT License
2.94k stars 87 forks source link

GUI extract on zip files causes window to lockup with no additional window popup #133

Closed Corallus-Caninus closed 3 years ago

Corallus-Caninus commented 3 years ago

Trying to extract a zip from the GUI causes the window to lock. I suspect this is due to not handling the sub window file explorer popup. Window does not respond to kill (super+backspace) signal presumably due to phantom sub window focus.

Steps taken to reproduce:

  1. Download a zip from Firefox and open.
  2. click extract in the window that pops up.
georgewsinger commented 3 years ago

Video replication of bug. I'm able to replicate this bug in Simula, but not in rootston (our reference compositor that we use for learning purposes). Here's a video: https://youtu.be/HT4WBk7Teo8

:hourglass_flowing_sand: Making Pernosco traces now for us to study.

georgewsinger commented 3 years ago

We've been fighting through some bugs to get our traces working. Here's Rootston.FirefoxUnzipExtract which might provide some insight. Still need to sort through some things to get a Simula trace. After that, what's causing this bug should be pretty apparent in the comparison between the two traces.

georgewsinger commented 3 years ago

We were able to get Simula.FirefoxUnzipExtract up and running, so now have the ability to compare the working vs. non-working traces.

georgewsinger commented 3 years ago

:heavy_check_mark: Fixed in https://github.com/SimulaVR/Simula/commit/92ae71d83780e59c5b32e04d7ec8874fd3190f05 on dev branch. @Corallus-Caninus