SimulaVR / Simula

Linux VR Desktop
MIT License
2.91k stars 87 forks source link

README.md has deprecated update instructions #135

Closed Corallus-Caninus closed 3 years ago

Corallus-Caninus commented 3 years ago

instructions to update Simula are not reproducible on Ubuntu 20.04. Does the Nix/Cachix runtime check update automatically now?

georgewsinger commented 3 years ago

Were you on master or dev branch when you tried to update? Did it build but fail to launch, or did it not build anything at all?

Here's our current command for reference:

updateSimula() {
    checkInstallNix
    checkInstallCachix
    cachix use simula

    if [ -z $1 ]; then
        git pull origin master
        NIXPKGS_ALLOW_UNFREE=1 nix-build -Q default.nix --arg onNixOS "$(checkIfNixOS)" --arg devBuild "false"
    else
        switchToNix
        git pull origin dev
        NIXPKGS_ALLOW_UNFREE=1 nix-build -Q -K default.nix --arg onNixOS "$(checkIfNixOS)" --arg devBuild "true"
        switchToLocal
    fi
}
georgewsinger commented 3 years ago

The issue (I think) was that our updateSimula() shell command wasn't updating git submodules. Fixed in https://github.com/SimulaVR/Simula/commit/a88f9dbf7ccaef704bfad29cfd6e571241d68da9 and pushed to master.

LMK if this doesn't fix the issue, and I'll reopen.

Corallus-Caninus commented 3 years ago

This is completely my fault.

I cancelled a build when cachix/nix fell through and started building natively for my platform and somehow got Simula to run anyways. Allowing installSimula to complete created the updateSimula.sh script for me and I cannot reproduce this anymore. (I didn't have updateSImula.sh at all)

georgewsinger commented 3 years ago

No worries. A fail safe way to update is just to reclone/re-run the install command:

git clone --recursive https://github.com/SimulaVR/Simula SimulaUpdate
cd SimulaUpdate
source ./utils/Helpers.sh && installSimula

This is less convenient than running updateSimula, but it should always work :]