SimulaVR / godot-haskell

Haskell bindings for GdNative
BSD 3-Clause "New" or "Revised" License
171 stars 17 forks source link

Generate against 3.1-stable api #18

Closed lboklin closed 5 years ago

lboklin commented 5 years ago

Please review these files specifically:

src-generate/Generate.hs 
src/Godot/Gdnative/Internal/Api.hs 
src/Godot/Gdnative/Internal/Gdnative.chs
KaneTW commented 5 years ago

Looks correct. Did you test the videodecoder/net APIs?

lboklin commented 5 years ago

Only so far as making sure a test godot-haskell project runs in godot-3.1-stable

KaneTW commented 5 years ago

Probably good enough. The crashes if something's wrong with the API are usually pretty obvious.

lboklin commented 5 years ago

Or to be honest I didn't check this commit on its own, but in conjunction with my other incoming PR, but it shouldn't make a difference.