SimulatedGREG / electron-vue

An Electron & Vue.js quick start boilerplate with vue-cli scaffolding, common Vue plugins, electron-packager/electron-builder, unit/e2e testing, vue-devtools, and webpack.
https://simulatedgreg.gitbooks.io/electron-vue/content/
MIT License
15.48k stars 1.55k forks source link

Differential download of electron-updater doesn't work because of version mismatch #708

Open pansila opened 6 years ago

pansila commented 6 years ago
Describe the issue / bug.

Differential download of electron-updater doesn't work because of version mismatch, it looks like that electron-builder included in the boilerplate doesn't work well with latest electron-updater

How can I reproduce this problem?

I was using vue-cli to create the project as the doc suggests. Then I got the following version of electron-builder in my package.json. "electron-builder": "^19.19.1"

Later after some work, I added the latest the electron-updater in the index.js as the doc suggests. "electron-updater": "^3.1.2"

It mostly worked well except for the differential download, which always failed because it can't find the old installer file "__installer.exe", while there was an installer.exe in the %APPDATA% instead.

Error log:

[2018-09-30 22:58:07.574] [error] Cannot download differentially, fallback to full download: Error: ENOENT: no such file or directory, open 'C:\Users\xxx\AppData\Roaming\app-product-name\__installer.exe'

After some dig, I found that it's a version mismatch issue that newer version electron-updater was expecting __installer.exe while older version electron-builder was generating installer.exe.

It would be great to lock the version of electron-updater in the package.json of the boilerplate.

Tell me about your development environment.
pansila commented 6 years ago

After updating electron-builder, differential download works again, it still would be great to lock the electron-updater version in some regard. "electron-builder": "^20.19.2"