search

SinTh0r4s / ExampleMod1.7.10

An example mod for Minecraft 1.7.10 with Forge focussed on a stable setup.
MIT License
25 stars 90 forks source link

Automatic versioning #34

Open TheElan opened 2 years ago

TheElan commented 2 years ago

It would be nice to have automatic minor or major version bump on each PR. This way nobody needs to remember to tag things.

SinTh0r4s commented 2 years ago

Automatically parse Tag and add an incremented to merge commit. But that will add friction for bumping the major versions manually. It would add a step to remove the current tag to the process. Is there an alternative?

TheElan commented 2 years ago

Was thinking the same, would be a tad problematic when we want a major version bump. Maybe we can drive this with a convention like always update minor, unless commit message contains [major update] (should be included in PR title so merge commit includes this in it) and script should bump major

TheElan commented 2 years ago

if somebody misses this thing you could always make dummy commit into master (or a PR with it) to trigger tagging

SinTh0r4s commented 2 years ago

https://axion-release-plugin.readthedocs.io/en/latest/

So to summarize:

Firstly, we need to check how forge handles funny semver variants to see if we can fool them somehow.

Secondly, to change the versioning of all mods (again!) will require some serious convincing on the staff. They want something working with all mods and be done with it. Not learn another system (the sad truth). So we might need to prepare some good selling points

Thirdly, some people have issues with syncing git tags to master. How could we Adresse that?