search

SinTh0r4s / ExampleMod1.7.10

An example mod for Minecraft 1.7.10 with Forge focussed on a stable setup.
MIT License
28 stars 104 forks source link

Jenkins version string fix #6

Closed SinTh0r4s closed 2 years ago

SinTh0r4s commented 2 years ago

Jenkins' Git detects a chmod on build.gradle as a file change and subsequently, adds a .dirty on the version string. This fix works, but is it too hacky? What do you guys think?

basdxz commented 2 years ago

Fix is fine, only thing you could do better is have it bound to one of the javaCompile tasks or etc. Or perhaps the setupCIWorkspace?

SinTh0r4s commented 2 years ago

But it must be run before gitVersion() in the next line