search

SinadShan / PassVault

Electron based cross-platform desktop application for managing passwords
3 stars 0 forks source link

Fix- open link in external browser #4

Closed ToluAkin closed 3 years ago

ToluAkin commented 3 years ago

Fix for issue #3

ToluAkin commented 3 years ago

@SinadShan Kindly review. Thank you!

SinadShan commented 3 years ago

Thanks for your contribution. This wasn't exactly what was intended, it would be better to open the link in the user's default browser instead of a browserWindow of the app. Perhaps you could take a look at this

ToluAkin commented 3 years ago

Thanks for your contribution. This wasn't exactly what was intended, it would be better to open the link in the user's default browser instead of a browserWindow of the app. Perhaps you could take a look at this

Updating now

ToluAkin commented 3 years ago

@SinadShan I got my solution here

SinadShan commented 3 years ago

Thanks again, but your solution has some problems. You are creating another window apart from the main browserWindow win ,and that too not from the main process. Your code should work fine in the main process i.e, app.js, but it seems the shell API is having some problems with opening the url, similar to this issue here. So I suggest ditching this method and use exec to run the shell command xdg-open https://github.com/SinadShan/PassVault/releases, which will open the link in an external browser.