search

Sinapse-Energia / CMS-SDL

Development of a new way of CMS data management
0 stars 0 forks source link

[Bugs] Problems found during integration of SDL - Get Monitoring Data #5

Open ralcaide opened 6 years ago

ralcaide commented 6 years ago

Resume of integration and bugs / improvements required found

BUGS

  1. Not working if the selected device does not have any real data. Fixed by Enbake
  2. Unreal values are nil sometimes. Fixed by Sinapse
  3. Deletion of minimum and maximum values of an array provokes empty arrays when all the values are the same. Fixed by Sinapse
  4. @Arr containing values to calculate mean is not reset, so there are valid values even in intervals without valid data. Fixed by Sinapse
  5. Real data and unreal data returned objects are different: [:current] vs ["current"]. Fixed by Sinapse

IMPROVEMENTS

  1. Not working well the start_date and end_date are different days, neither in a interval of a day. Done by Sinapse
  2. Performance: It is very slow. A lot of access to the database in order to write samples. TO BE IMPROVED. Partial improvement developed by Sinapse in order to limit the number of devices to be used to calculate unreal data
  3. All the code is in a controller, not easy to reuse. To be included in a mode. Done by Sinapse
  4. Use of global variables is not very good. TO BE IMPROVED
  5. Code is not DRY. TO BE IMPROVED