search

Sindarin27 / FireproofItems

Make items with the fireproof tag fireproof, simple as that.
1 stars 2 forks source link

Crash on world load in 1.18.2 #6

Open alcatrazEscapee opened 1 year ago

alcatrazEscapee commented 1 year ago

Minecraft 1.18.2 Fireproof Items 1.1

This mod is compiled against 1.18.1:

https://github.com/Sindarin27/FireproofItems/blob/9911e662ecbcf09342c966a233498f2bc53e4dea/build.gradle#L130

However on CurseForge, it is marked as compatible with 1.18.1 and 1.18.2:

img

When loaded in 1.18.2, however, this will crash with a NoSuchMethodError fairly soon after joining a world, due to it using methods that have been removed between the two versions:

java.lang.NoSuchMethodError: 'net.minecraft.tags.TagCollection net.minecraft.tags.ItemTags.m_13193_()'
    at sindarin.fireproofitems.FireProofItemsMod.onEntitySpawn(FireProofItemsMod.java:27)
Sindarin27 commented 1 year ago

Huh, interesting! I thought I tested this before. I'll look into it once I have some free time (but if someone wants to make a PR to do this, I'll gladly accept it too :)