objornstad
commented
4 months ago :)
On 5/31/24 7:46 AM, James Azam wrote:
You don't often get email from @.*** Learn why this is important https://aka.ms/LearnAboutSenderIdentification
Hi Sinead, thanks so much for building this app. I've found it useful for teaching and quick exploration.
From a user perspective, I think it would be easier to specify the |model| argument in |run_shiny()| if you exposed or documented the options more explicitly.
Two options:
- List out the options in the model argument with |model = c("SIR", "SIRS", "SIS")|, which means by default, it uses the "SIR" model. This aligns with the tidyverse design recommendation https://design.tidyverse.org/enumerate-options.html.
- List it out in the documentation. It currently says: https://github.com/SineadMorris/shinySIR/blob/2ba1d2d53f54156d8a8fd1c924700d006e11ddde/R/run_shiny.R#L4 https://github.com/SineadMorris/shinySIR/blob/2ba1d2d53f54156d8a8fd1c924700d006e11ddde/R/run_shiny.R#L4, which made me try "SIR with vaccination" but errored. This can rather say "models include SIR, SIRS, and SIS".
I'm happy to submit a PR to fix this if you are happy with my suggestion. Thanks so much.
— Reply to this email directly, view it on GitHub https://github.com/SineadMorris/shinySIR/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJEMKDEFGV7DKCTSSMOW4RDZFBPITAVCNFSM6AAAAABISVD3COVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDONRVG44TKMY. You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- Ottar N. Bjornstad ph: 814-863-2983 Distinguished Professor of Entomology, Biology and affiliate Professor of Statistics. J. Lloyd & Dorothy Foehr Huck Endowed Chair of Epidemiology. Elected fellow of the Norwegian Academy of Science and Letters, American Association for the Advancement of Sciences and the Ecological Society of America Epidemics v2:https://link.springer.com/book/10.1007/978-3-031-12056-5
--------------TbX7XXuoHZnmX3V4ffLdFxkM Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
:)
Hi Sinead, thanks so much for building this app. I've found it useful for teaching and quick exploration.
From a user perspective, I think it would be easier to specify the
modelargument inrun_shiny()if you exposed or documented the options more explicitly.Two options:
- List out the options in the model argument with
model = c("SIR", "SIRS", "SIS"), which means by default, it uses the "SIR" model. This aligns with the tidyverse design recommendation.- List it out in the documentation. It currently says: https://github.com/SineadMorris/shinySIR/blob/2ba1d2d53f54156d8a8fd1c924700d006e11ddde/R/run_shiny.R#L4, which made me try "SIR with vaccination" but errored. This can rather say "models include SIR, SIRS, and SIS".
I'm happy to submit a PR to fix this if you are happy with my suggestion. Thanks so much.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
-- Ottar N. Bjornstad ph: 814-863-2983 Distinguished Professor of Entomology, Biology and affiliate Professor of Statistics. J. Lloyd & Dorothy Foehr Huck Endowed Chair of Epidemiology. Elected fellow of the Norwegian Academy of Science and Letters, American Association for the Advancement of Sciences and the Ecological Society of America Epidemics v2: https://link.springer.com/book/10.1007/978-3-031-12056-5
--------------TbX7XXuoHZnmX3V4ffLdFxkM--
SineadMorris
jamesmbaazam
Hi Sinead, thanks so much for building this app. I've found it useful for teaching and quick exploration.
From a user perspective, I think it would be easier to specify the
modelargument inrun_shiny()if you exposed or documented the options more explicitly.Two options:
model = c("SIR", "SIRS", "SIS"), which means by default, it uses the "SIR" model. This aligns with the tidyverse design recommendation.I'm happy to submit a PR to fix this if you are happy with my suggestion. Thanks so much.