search

Sinetheta / blueprintnotincluded

Container for 3 components of blueprintnotincluded.org
https://blueprintnotincluded.org
MIT License
14 stars 4 forks source link

Fix unintended tool switch when typing #38

Closed SunnyHuangCodebase closed 5 months ago

SunnyHuangCodebase commented 8 months ago

Resolves issue #1

Bug: Pressing the "b" key erroneously activates the build tool when user is attempting to type into a textbox.

Fix: Ignore "b" key presses when typing into <textarea> and <input> elements.

Sinetheta commented 5 months ago

Thanks for the submission @SunnyHuangCodebase sorry I didn't notice it earlier. The "Delete" path also suffers the same problem but I'll merge this now and look into the logic where the handler is applied.

Sinetheta commented 5 months ago

I think CI didn't run because of a setting on this repository. The docs make it sound like I should be able to "Approve and run" but that option doesn't appear. Maybe because I took so long to respond that it's gone?

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks