Singular-Genomics / singular-demux

Singular Genomics Demultiplexing Tool
Other
16 stars 0 forks source link

Compare min-delta to minimum distance between samples #50

Open jiangweiyao opened 11 months ago

jiangweiyao commented 11 months ago

Hi Nils,

I talked to Ryan, and we think a reasonable solution to the min-delta problem would be to compare the minimum distance between the samples to the min-delta. If the min distance between samples is not greater than the min-delta, then throw a warning like " The hamming distance between and is . The min-delta is . Because the hamming distance is not greater than the min-delta, reads may not get assigned to these samples. Please consider changing the min-delta parameter."

I think the code already compares the hamming distance between the samples, so I think this should not cause too many downstream changes. Thanks.

nh13 commented 11 months ago

@jiangweiyao sounds good to me