Open omiras opened 3 years ago
omiras
commented
3 years ago 
didac3141592
commented
3 years ago After signing up and choosing the "I want to adopt" option, animals don't appear in the slide. You have to reload the page in order for them to appear.
After fixing the "add favorite animal" functionality, images are not properly recovered in view "my favorite animals". This has been fixed as well.
I realized animal size does not appear on the animal cards in the slider.
Also, although the admin animals view was loading using the tab on the left, the tab bar disappeared when the view was loaded. I fixed it so that the view appeared with the tab, as the animal slider and the favorite animals views do. For the sake of the nomenclature, I changed the parent route from /animals/ to /main/. After that, there was no need for a back button in the header of the view. I removed it.
The variables.css file was duplicated: there was a file in the /theme folder and one in the /components folder. I removed the one from the components folder.
I found some issues with the router: no route was pushed after animal deleted, por example. It deletes it, but the animal stays loaded in the form with all the data. We need to check it.
Now, ANY animal with the disabled property set to true won't appear on the slider. However, they do not appear in under your animals in the admin-animals view. I found this to be the expected behaviour, but you may want them to appear anyway.
When there is no animals in the slider to show, the loading spinner just keeps loading. We should prompt the user a message telling them there is no more animals to see at the moment instead of the loading spinner.
didac3141592
commented
3 years ago Changed all routes to use names which fixed most of the routing issues.
Also deleted dark-theme color variables. Now, app always displays light theme.