SinguloStation13 / SinguloStation-Blue

GNU Affero General Public License v3.0
0 stars 6 forks source link

[MIRROR] Fix for Corporate Benches and Chair deconstruction + Time to build for chairs #1008

Open SinguloBot opened 2 years ago

SinguloBot commented 2 years ago

Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/7594

About The Pull Request

This PR aim to fix some stuff I forgot to fix in the https://github.com/BeeStation/BeeStation-Hornet/pull/7547/, the fixes are related to the corporate bench returning a massive ERROR icon due to GAGs issues and fixed a bug that, if you moved while deconstructing any chair, it would override the deconstruction time. Also made all the chairs to actually take time to build instead of being insta-build, since some chairs actually took time (see wooden chair) while the grand majority where an instant build.

Also I want to credit https://github.com/Imaginos16 (aka PositiveEntropy) from /tg/ for making the icon for the Wooden chairs icons and the armchair/Sofa icons, and I forgot to update the PR before being merged to credit you properly, apoligies!

Why It's Good For The Game

Fixes are good and also i forgot to actually credit someone, hopefully this will be good enough.

Testing Photographs and Procedure

Screenshots&Videos ~~No real screenshot to be put in, since it's a fix.~~ Turns out Better put on a screen: ![immagine](https://user-images.githubusercontent.com/75247747/188018106-5a3110f6-8624-491b-be47-4cc298916668.png)

Changelog

:cl: PigeonVerde322, PositiveEntropy add: FORGOT to credit PositiveEntropy for the Wooden chairs icons and the armchair/Sofa icons in the previous PR, apoligies! add: Added time-to-build to all the chairs add: Courtesy of para, now benches can be coloured fix: fixed a bug that, if you moved while deconstructing any chair, it would override the deconstruction time fix: fixed Corporate benches being broken, now they use a different system than GAGs, also courtesy of para, now benches padding can be coloured! /:cl: