SinguloStation13 / SinguloStation-Blue

GNU Affero General Public License v3.0
0 stars 6 forks source link

[MIRROR] Tweaks xeno chestbursting #879

Closed SinguloBot closed 2 years ago

SinguloBot commented 2 years ago

Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/6885

About The Pull Request

Someone suggested this to me at some point a while ago, but I never got around to coding it in (so sorry to whoever that was). This PR makes it so that chestbursters won't gib their hosts. Instead, it'll just kill them and make all the organs in their chest spill out. I also tweaked the logic on alien embryo growths to be a bit more consistent. Now, instead of checking prob(3) every time the egg processes, it just sets a timer from 1-1.5 minutes for each stage and progresses when that timer's up. If the embryo's removed, the stage timer resets. There's probably a better way to manage the stage times, but I'm not entirely sure if there's something else I should use.

Why It's Good For The Game

Because full gibbing + brain deletion from a worm coming out of you never really made sense to me. That, and getting fully round removed kinda sucks.

The change for growth should also hopefully make embryo growth more consistent.

Testing Photographs and Procedure

It compiles, and there's no runtimes or incredibly broken things during embryo processing/chestbursting.

Changelog

:cl: tweak: Xeno chestbursters no longer gib their hosts. tweak: Tweaks alien embryo growth logic /:cl:

github-actions[bot] commented 2 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.