SinguloStation13 / SinguloStation-Blue

GNU Affero General Public License v3.0
0 stars 6 forks source link

[MIRROR] [TGUI] Upgrades terser to 5.14.2 #891

Closed SinguloBot closed 2 years ago

SinguloBot commented 2 years ago

Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/7332

About The Pull Request

Updates the resolution for terser-webpack-plugin and terser to force a minimum version of 5.14.2.

Testing Photographs and Procedure

Testing procedure:

  1. Fully clean the build environment using juke
  2. Rebuild TGUI and run the linter/tests
  3. Build DM and launch a new server
  4. Verify that TG-chat loads
  5. Spawn as captain and interact with different TGUI menus
Build + inline tests ```node ❯ ../tools/build/build clean-all Using system-wide Node v16.16.0 :: Juke Build version 0.8.1 => Starting 'tgui-clean' => Finished 'tgui-clean' in 0.041s => Starting 'clean' => Finished 'clean' in 0s => Starting 'clean-all' :: Cleaning up data/logs :: Cleaning up global yarn cache ➤ YN0000: Done in 0s 17ms => Finished 'clean-all' in 0.3s => Done in 0.343s repo/tgui on  terser-upgrade [!⇣] via  v16.16.0 ❯ ../tools/build/build tgui tgui-lint tgui-test Using system-wide Node v16.16.0 :: Juke Build version 0.8.1 => Starting 'yarn' ➤ YN0000: ┌ Resolution step ➤ YN0000: └ Completed in 0s 448ms ➤ YN0000: ┌ Fetch step ➤ YN0013: │ 4 packages were already cached, 854 had to be fetched ➤ YN0000: └ Completed in 25s 423ms ➤ YN0000: ┌ Link step ➤ YN0000: │ ESM support for PnP uses the experimental loader API and is therefore experimental ➤ YN0000: └ Completed in 0s 538ms ➤ YN0000: Done with warnings in 26s 520ms => Finished 'yarn' in 26.901s => Starting 'tgui' => Starting 'tgui-test' => Starting 'tgui-eslint' => Starting 'tgui-tsc' PASS packages/common/collections.spec.ts PASS packages/common/react.spec.ts Test Suites: 2 passed, 2 total Tests: 4 passed, 4 total Snapshots: 0 total Time: 1.03 s Ran all test suites. => Finished 'tgui-test' in 2.285s => Finished 'tgui-tsc' in 2.903s => Finished 'tgui-eslint' in 10.468s assets by path *.js 1.47 MiB asset tgui.bundle.js 1.03 MiB [emitted] [minimized] (name: tgui) asset tgui-panel.bundle.js 444 KiB [emitted] [minimized] (name: tgui-panel) assets by path *.css 296 KiB asset tgui.bundle.css 193 KiB [emitted] (name: tgui) asset tgui-panel.bundle.css 103 KiB [emitted] (name: tgui-panel) Entrypoint tgui 1.22 MiB = tgui.bundle.css 193 KiB tgui.bundle.js 1.03 MiB Entrypoint tgui-panel 547 KiB = tgui-panel.bundle.css 103 KiB tgui-panel.bundle.js 444 KiB 2022-07-22 12:12:33: webpack 5.69.0 compiled successfully in 15604 ms => Finished 'tgui' in 17.671s => Done in 44.632s ```
Screenshots ![image](https://user-images.githubusercontent.com/26130695/180610347-baf861e9-42ea-4602-aead-9ff540d872e6.png) ![image](https://user-images.githubusercontent.com/26130695/180610375-7a2301d3-114e-4cf2-bb33-b8f03c5d0ace.png) ![image](https://user-images.githubusercontent.com/26130695/180610393-1e2f7bd9-bebe-433a-809f-8d982205ece6.png) ![image](https://user-images.githubusercontent.com/26130695/180610408-605301b9-d330-4298-b075-3038ee371c7c.png) ![image](https://user-images.githubusercontent.com/26130695/180610417-b4aa0466-702e-4898-904e-1d9f16a04209.png) ![image](https://user-images.githubusercontent.com/26130695/180610441-9e2e1e72-80f2-4126-9667-9fd8530f9838.png) ![image](https://user-images.githubusercontent.com/26130695/180610482-3757d543-697a-4858-b442-6d7044778f3f.png)

Changelog

:cl: server: Upgrades the TGUI dependency terser to 5.14.2 /:cl:

github-actions[bot] commented 2 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.