search

SinguloStation13 / SinguloStation-Blue

GNU Affero General Public License v3.0
0 stars 6 forks source link

[MIRROR] Fix duplicates in minimal runtimes and lag caused by it #901

Closed SinguloBot closed 2 years ago

SinguloBot commented 2 years ago

Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/7399

About The Pull Request

[issue link stripped]

If there's a lot of runtimes, it was iterating (runtimes_total)*(runtimes_sources) times instead of (runtimes_sources) times causing big lag lots of duplicates

Why It's Good For The Game

Bug bad

Testing Photographs and Procedure

Screenshots&Videos ![image](https://user-images.githubusercontent.com/10366817/181622472-9d20bda8-ead8-40be-af4c-182004ce809e.png) vs linear view from regular menu ![image](https://user-images.githubusercontent.com/10366817/181622530-b3503408-7292-493c-b7c9-c405de2a9678.png)

Changelog

:cl: fix: Minimal runtimes menu will no longer show duplicates and lag /:cl:

github-actions[bot] commented 2 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.