github-actions[bot]
commented
2 years ago This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.
Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/7363
About The Pull Request
The radio uplink now takes the form of a hidden radio channel, being :d. This channel never appears while examining the headset, using in hand, and doesn't actually send any messages to people. However, speaking a message containing a codeword into this :d channel causes the uplink to open up (ex if your message was pizza then I like pizza will still trigger it)
and mimes are forced into using a pda uplink for obvious reasons
Why It's Good For The Game
Frankly, theres no point in not using the PDA uplink at the moment. The current radio uplink cuts you off from common chat for an extended period of time, and you have to manually set it back to the common frequency (which might be a headache if you forget what the code is). The pen takes a while to input a code, and is harder to use with other pen types. Implant is fine, but some might see it as a waste of tc. This new radio uplink gives a unique set of strengths and drawbacks no other uplink can provide.
Pros: Doesn't deduct TC Can be used handcuffed Easier code to remember Makes the "Failsafe code" far more viable as a last resort
Cons: Can't be used if mute People can still hear you whispering, possibly giving away your uplink (burying the codeword in a longer message can offset this) may trigger failsafe/unlock by accident
Testing Photographs and Procedure
Screenshots&Videos
Changelog
:cl: add: Added the :d radio channel :add: Added checks for said :d channel :del: Removed the old radio uplink tweak: Tweaked the ic notes, traitor splash screen, and code generation to reflect the new uplink /:cl: