github-actions[bot]
commented
2 years ago This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.
Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/7293
Now checks if user is incorporeal in a more sane location. Necessary change to prevent the menu from being opened and then used after phasing back out.
About The Pull Request
1) Adjusts the timing of the incorporeal check when stripping items - The check now occurs when the user tries to start stripping instead of only when they try to open the stripping window. This check runs on both try_equip and try_unequip. This adjustment was essential to allowing revenants to strip because with the check only upon opening the window a revenant could simply leave the window open and continue stripping while invisible once it was.
2) Gives revenants the ability to phase in and out at will, which respects forced reveal timers on other abilities. This ability costs nothing to use and has no cooldown. You can strip players while corporeal and can also drag objects and players around.
3) Adds this sprite for the ability, by PigeonVerde / @ PestoVerde322:
4) Enables Revenants to ctrl + click to pull. This works when they are incorporeal, but actually pulling something does not work. (This is also how it works currently if you right click -> Pull, the only change here is enabling the shortcut)
Why It's Good For The Game
It adds more options to revenant players, re-enables stripping in a balanced way and also patches an oversight in #7177 that allows jaunted mobs to still strip. I'll explain this in detail privately to maintainers if necessary, DM me on discord.
Testing Photographs and Procedure
Screenshots&Videos
Basic test which includes stripping demonstration.  Trying to steal items while phased out:  Trying to phase out after ability usage:  * Ability has no cooldown and functions as intended * Ability does not allow revenant to bypass forced reveal upon other ability use * Revenant cannot begin stripping items unless they are corporeal * Even if revenant was willfully corporeal when using an ability, they will automatically vanish as soon as possible. The ability sits between Night Vision and Telepathy on the ability bar: Changelog
:cl: PestoVerde322, Rukofamicom add: Revenants may now reveal themselves at will with a new ability! While corporeal revenants are vulnerable but able to perform the same basic functions that other simplemobs can, such as stripping players and dragging things around. /:cl: