github-actions[bot]
commented
2 years ago This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.
Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/7461
About The Pull Request
Fail2topic ip blacklisting used the findtext proc which returns the index of the found text. This means that IP was getting set to 1 after being run through the regex. This code changes it so that we use regex/proc/Find, which sets the match variable of the regex to the located text, meaning that IPs will be able to be banned properly.
Why It's Good For The Game
Ability to stop incoming DoS attacks.
Testing Photographs and Procedure
This line of code can now be reached. As long as there are no other issues which I didn't test for, the DoS attacks should be prevented.
Changelog
:cl: fix: Fixes fail2topic firewall banning not working. /:cl: