SinguloStation13 / SinguloStation-Blue

GNU Affero General Public License v3.0
0 stars 6 forks source link

[MIRROR] Makes the transfer valve and signaler logging a little more robust, also makes it tgui. #937

Open SinguloBot opened 2 years ago

SinguloBot commented 2 years ago

Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/7412

About The Pull Request

Why It's Good For The Game

Logs being a little bit more robust is good. It being unclear who actually opened the valve bad.

Testing Photographs and Procedure

Screenshots&Videos Put screenshots and videos here with an empty line between the screenshots and the `
` tags. Opening it manually (thru the UI) ![image](https://user-images.githubusercontent.com/22431091/181996308-fb337936-87c6-41ef-b62a-38db66e81171.png) Opening via a signaler ![image](https://user-images.githubusercontent.com/22431091/181996405-865793a5-23ab-4603-9d74-b33936be7860.png) Opening via a proximity sensor ![image](https://user-images.githubusercontent.com/22431091/181996451-4d78bbf9-3a59-4223-8ebf-f690ee224850.png)

Changelog

:cl: add: The tank transfer valve now uses tgui for it's interface admin: Added more robust logging for tank transfer valves and signalers /:cl:

github-actions[bot] commented 2 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.