Also includes a runtime fix for recharger examine text when the item's power cell is null
Why It's Good For The Game
Up to date modular pc code is good and lots of QoL fixes here
Testing Photographs and Procedure
Screenshots&Videos
Early testing video for expansion slot PR, also shows new ejection system
https://user-images.githubusercontent.com/10366817/180596955-78a5ef52-6bcb-4a48-b1e8-c6b116acf945.mp4
Icons and new software download tool are nearly identical to the ones from TG's testing video, their names are different but everything else is the same, the Cargo app we have that they don't uses `fa-credit-card`
https://user-images.githubusercontent.com/3625094/107362787-46f0a680-6aea-11eb-9077-7ca6ad9d34a0.mp4
Notification system works as expected with the SM, although I will note the beep is the same as the PDA messenger one which I have trouble hearing, but for consistency it'll stay as that.
Changelog
:cl:
refactor: Software Downloader program UI revamp
tweak: The NtOS home screen has been updated with disk and ID eject buttons.
add: Added support for modular PC expansion bays, or hardware bays designed to be used by nonessential hardware. Devices have a limited number of bays (tablets less than others).
balance: The AI card slot, printer, and APC-siphoning recharger are now expansion bay hardware.
balance: The modular PC atmos scanner now requires a new expansion bay hardware item - the sensor package. Certain shift-start tablets have been adjusted to reflect this.
refactor: Modular PC card readers have been split -- The primary ID card reader, which comes pre-installed on nearly all devices, and a secondary ID card reader which is an expansion bay hardware and will need to be purchased separately. Certain shift-start devices have a secondary reader pre-installed.
fix: Buying a tablet from the Laptop/Tablet vendor, and paying extra for the mini-printer, will now attach the correct printer rather than attempt to stuff a laptop printer into a tablet and silently fail but still take your cash.
add: Added icons for all modular computer programs
add: Supermatter Monitoring will now send notifications if the app is closed with a supermatter selected, and the selected supermatter starts delaminating.
fix: Modular computers can now be attacked with non-help intent.
code: Fixes a runtime error with recharger examine text if the inserted item's power cell is null
fix: Fixed a runtime with ID modification program when the second ID slot is missing.
fix: ID modification program now follows the standard for ID reading and requires you to insert your card.
tweak: Primary and secondary ID card slots in ModPCs have separate names to make it easier to differentiate.
/:cl:
Original PR: https://github.com/BeeStation/BeeStation-Hornet/pull/7338
About The Pull Request
Depends on #7335 - I will forcepush a rebased version without said commits when mergedPorts:
Also includes a runtime fix for recharger examine text when the item's power cell is null
Why It's Good For The Game
Up to date modular pc code is good and lots of QoL fixes here
Testing Photographs and Procedure
Screenshots&Videos
Early testing video for expansion slot PR, also shows new ejection system https://user-images.githubusercontent.com/10366817/180596955-78a5ef52-6bcb-4a48-b1e8-c6b116acf945.mp4 Icons and new software download tool are nearly identical to the ones from TG's testing video, their names are different but everything else is the same, the Cargo app we have that they don't uses `fa-credit-card` https://user-images.githubusercontent.com/3625094/107362787-46f0a680-6aea-11eb-9077-7ca6ad9d34a0.mp4 Notification system works as expected with the SM, although I will note the beep is the same as the PDA messenger one which I have trouble hearing, but for consistency it'll stay as that.Changelog
:cl: refactor: Software Downloader program UI revamp tweak: The NtOS home screen has been updated with disk and ID eject buttons. add: Added support for modular PC expansion bays, or hardware bays designed to be used by nonessential hardware. Devices have a limited number of bays (tablets less than others). balance: The AI card slot, printer, and APC-siphoning recharger are now expansion bay hardware. balance: The modular PC atmos scanner now requires a new expansion bay hardware item - the sensor package. Certain shift-start tablets have been adjusted to reflect this. refactor: Modular PC card readers have been split -- The primary ID card reader, which comes pre-installed on nearly all devices, and a secondary ID card reader which is an expansion bay hardware and will need to be purchased separately. Certain shift-start devices have a secondary reader pre-installed. fix: Buying a tablet from the Laptop/Tablet vendor, and paying extra for the mini-printer, will now attach the correct printer rather than attempt to stuff a laptop printer into a tablet and silently fail but still take your cash. add: Added icons for all modular computer programs add: Supermatter Monitoring will now send notifications if the app is closed with a supermatter selected, and the selected supermatter starts delaminating. fix: Modular computers can now be attacked with non-help intent. code: Fixes a runtime error with recharger examine text if the inserted item's power cell is null fix: Fixed a runtime with ID modification program when the second ID slot is missing. fix: ID modification program now follows the standard for ID reading and requires you to insert your card. tweak: Primary and secondary ID card slots in ModPCs have separate names to make it easier to differentiate. /:cl: