Bug with Gladiator and Templar status

[GoogleCodeExporter]

Core revision: 166

Bug description: Bug with Gladiators and Templar stats

What steps will reproduce the problem?:

1 - Equip two weapons of same type like two daggers on character;

2 - Relogin;

3 - Remove them and equip two weapons of other type like a swords;

4 - Finish ;) Now you have status of 4 weapons

5 - Now your Gladiator or Templar are stronger, with simple skills hitting 5k 
+. You gonna need just 3 hits to kill anyone.

Original issue reported on code.google.com by endrigo....@gmail.com on 16 Mar 2011 at 7:17

[GoogleCodeExporter]

Dual-Wielding and the Weapon Masteries has long been known to be bugged. I took 
a look at it a long time ago and it was no trivial fix.

Original comment by ZeroSign...@gmail.com on 17 Mar 2011 at 10:21

• Changed state: Accepted

[GoogleCodeExporter]

Issue 122 has been merged into this issue.

Original comment by ZeroSign...@gmail.com on 23 Mar 2011 at 5:04

[GoogleCodeExporter]

Issue 251 has been merged into this issue.

Original comment by ZeroSign...@gmail.com on 7 Apr 2011 at 8:20

[GoogleCodeExporter]

patch files.
please test.

Original comment by pl6...@gmail.com on 9 Apr 2011 at 6:40

[GoogleCodeExporter]

merged...sorry

Original comment by pl6...@gmail.com on 9 Apr 2011 at 7:17

[GoogleCodeExporter]

bug fix

Original comment by pl6...@gmail.com on 9 Apr 2011 at 10:13

Attachments:

• DualWeaponMasteryFix2.patch

[GoogleCodeExporter]

This is a good step in the correct direction, however it does still suffer from 
a minor bug and that is when weapons are equipped that are of the same type, 
both weapons should still get the bonus.

Example:
Start a scout class
select self
//addskill 19
//add 100000094 2
unequip all weapons
then re-equip with both Sword For Training.

If you could fix that issue, then I think it should be able to be committed.

Original comment by ZeroSign...@gmail.com on 11 Apr 2011 at 6:43

• Changed state: Started

[GoogleCodeExporter]

i fixed it.

memo:
i found recomputeStats() is called many times when login.
this is heavy thing for performance.

Original comment by pl6...@gmail.com on 12 Apr 2011 at 1:44

Attachments:

• DualWeaponMasteryFix3_r257.patch

[GoogleCodeExporter]

pl6 very oustanding work so far. :)

I did find one little issue with it and that is when a better Passive Skill is 
added.
i.e.
Advanced Dagger Training I
to
Advanced Dagger Training II

The Weapon Mastery is not currently re-calculated and you have to swap or 
re-equip for it to go in effect. Considering that's the only issue it's pretty 
minor. Up to you whether you want to fix that issue or not, nevertheless it 
would be great to commit this very soon.

Original comment by ZeroSign...@gmail.com on 20 Apr 2011 at 2:09

[GoogleCodeExporter]

Committed Revision 271.

Original comment by ZeroSign...@gmail.com on 27 Apr 2011 at 2:18

• Changed state: Fixed