Sinistralis-DOS2-Mods / StatLib

A library for building a stat editor for Divinity Original Sin 2 with scripted stat support
MIT License
1 stars 1 forks source link

Break Up Scripts from Modifiers #6

Closed Mike-Sinistralis closed 6 years ago

Mike-Sinistralis commented 6 years ago

So, I went to work on my DoT implementation and realized this needs shared with my Scaling modifier since HoTs live there, and it's made me re-think how I handled scripts the past few days and I think I realized my mistake. Scripts need to be a seperate context from Modifiers, and they need to be able to pass functions to the modifiers. I think that will clean up the workflow greatly and better seperate the two ideas.

I am currently working on this. I am also making it so the namespacing happens as a pre-step. It will make working with fields like SkillProperties and WeaponBoost MUCH simpler. As it is, it's even confusing for me and I wrote the damn thing.

Mike-Sinistralis commented 6 years ago

I have this almost complete. Dead tired, so going to sleep. Will update documentation when I get up and push the change. Pretty happy with how this turned out. Cleaned up a lot of workflow.

Mike-Sinistralis commented 6 years ago

This has been completed