Sinono3 / souvlaki

A cross-platform library for handling OS media controls and metadata.
MIT License
80 stars 15 forks source link

Album art support #6

Closed Sinono3 closed 3 years ago

Sinono3 commented 3 years ago

This feature is also crucial to souvlaki, especially on Windows, where the album art is displayed on the screen when pressing any media key.

jpochyla commented 3 years ago

I'd love this as well, although I'm not sure how to represent the image. URL, or a type from the image crate? I'm not sure if any platform natively supports URLs, so maybe just the second one?

Sinono3 commented 3 years ago

Well, let's see:

I guess we can just take an URI as input, and if the user wants to use an image in memory, allow them to input that and just optimize according to each specific platform. For example: a video player wants to procedurally extract a thumbnail of a video, and then feed it to souvlaki. The input could be just an image from the image crate.

If we do have this behaviour, maybe separating it in a feature and warning users would be a good idea, since it could be disruptive.

jpochyla commented 3 years ago

Thanks for the research! Good to know that URL is the only way on MPRIS, and in the end it's not so complicated to download it asynchronously in MacOS, either.

Sinono3 commented 3 years ago

Closed with #8.