Sinytra / Connector

A compatibility layer that allows running Fabric mods on NeoForge
https://sinytra.org/docs/connector
MIT License
527 stars 22 forks source link

Replay mod viewer is showing different models #1124

Closed jimmytimmy65 closed 5 months ago

jimmytimmy65 commented 5 months ago

Minecraft version

1.20.1

Describe the bug

Replay mod viewer is showing different models

Steps to reproduce

  1. Record some gameplay in replay mod
  2. Exit out of the game
  3. play the replay
  4. 2024-06-03_07 02 25

...

Logs

No response

Additional context

I don't know if it's player problem or code problem but I hope someone could help me, I tried to delete multiple mods, changed to different models, and when it's a world gen or a block mod it's needs that mod to stay in the folder.

ferriarnus commented 5 months ago

What mods are you using? And did you change mods between making and watching the replay?

jimmytimmy65 commented 5 months ago

BCLib Simple Backups Dank Storage Rubidium Dynamic Lights Decorative Pavers Bad Packets Xaero's Map - Waystones Compability BotanyTrees Create Track Map Bountiful SuperMartijn642's Core Lib BotanyPotsTiers Chisel Reborn The Outer End Multipart Machines: Cooking Red’s More Structures RebornStorage Fabric Language Kotlin Better Nether Iron Bookshelves Botany Pots Ore Planting Mystical Adaptations Mekanism: Generators Amendments Garnished Botany Pots Waystones Jade Addons Fusion Cozy Home Cristel Lib Better End Just Enough Breeding Iron Furnaces ExtraStorage Create: Garnished Integrated API Sophisticated Backpacks Tempad VillagersPlus Epic Fight Enhanced Celestials LionfishAPI Builder's Delight EntityCulling Rings of Ascension MC Dungeons Artifacts Sophisticated Storage Multipart Machines: Storage Oculus Just Enough Professions (JEP) More Mekanism Processing Iron Shulker Boxes Simply Swords [Fabric & Forge] Storage Drawers Geologic Expansion Resourceful Lib Zeta Aquamirae (Forge) Refined Storage CorgiLib GeckoLib Sophisticated Core Iron Spawners .connector Hamsters Plus Mekanism-MoreSolarPanels Portable Mobs Connected Glass Memory Leak Fix Dynamic Asset Generator BotanyPots Deeper and Darker Mystical Agriculture Towns and Towers Corpse Creative Crafter TerraBlender (Forge) Additional Lights Kambrik MC Dungeons Weapons Create: Extended Cogwheels Tool Leveling+ Create: Structures Bookshelf Craftable Spawn Eggs YUNG's API (Forge) Jade 🔍 Traveler's Backpack BuddingCrystals Multipart Machines: Mining Shulker+ Resourceful Config Multipart Machines: Grinding ReplayMod Create Ore Excavation YUNG's Better End Island (Forge) Xaero's Minimap Trading Post Balm CTD Core Mo' Glowstone Litematica EdivadLib Cloth Config API (Fabric/Forge/NeoForge) Structure Gel API Moonlight Lib Dimensional Dungeons Mekanism Tools The Aether Animal Feeding Trough Aether: Lost Content Addon Cable Tiers Create: Steam 'n' Rails MaLiLib Supplementaries Mob Grinding Utils Additional Lanterns ESSENTIAL Mod Embeddium (Rubidium) Extra Just Enough Items Architectury API (Fabric/Forge/NeoForge) Xaero's World Map Mekanism Additions Easy Villagers FerriteCore ((Neo)Forge) The Twilight Forest EMI Trades (Villager Trading EMI Plugin) Decorative Lattices L_Ender 's Cataclysm Connector Extras Cucumber Library Integrated Dungeons and Structures Extra Disks EMI Loot Create Enchantment Industry When Dungeons Arise - Forge! Mekanism Iron Chests Knaves' Needs Iron Ender Chests Multipart Machines: Farming Create Embeddium Blueprint Mystical Agradditions Immersive Melodies Obscure API (Forge) Athena Trade Cycling AeroBlender Tool Stats Curios API Display Case Lootr (Forge & NeoForge) EMIffect (Status Effects EMI Plugin) Kotlin for Forge Just Enough Resources (JER) Quark Puzzles Lib V1.20.1_Crystalcraft_Unlimited_Raw_Ore_Update Mystical Agriculture Tiered Crystals Aethersteel Do a Barrel Roll Forgified Fabric API Integrated Stronghold EMI Refined Storage Addons playerAnimator The Aether: Redux More Villager Trades Sinytra Connector Weapons of Miracles - epic fight

Tried to change them into different versions, but didn't work :(

RoomAlex68 commented 5 months ago

This should be merged with issue #556

kakashi1464 commented 5 months ago

I'd recommend you use the Reforged Play instead of the Replay mod. https://github.com/ferriarnus/ReForgedPlay/tree/1.20.1

jimmytimmy65 commented 5 months ago

Still showing the same problem :( I even removed the cache and .connector. :(

jimmytimmy65 commented 5 months ago

Ok so for some reason I started a new world, the diamond chests from two different mods worked good, I then added snow pig mod still worked the same but the block hand model changed

image image

Is it anything to do with the data in the other world that confuses whenever there is someone that adds more mods? And if so is there anyway to reset it without removing any progress of the world?

VladisCrafter commented 5 months ago

Very, very known bug :<

I still haven't figured it out and the "solution" rn is just to keep the modlist constant or move to a new world whenever you need to add content mods.

ferriarnus commented 5 months ago

Right makes sense. The replay mod saves the numerical id of items. When new mods get added, these id's shift and you get this. This needs a registry sync to fix it (which is easier said then done).

jimmytimmy65 commented 5 months ago

Is there any way to change the id inside replay mod?

VladisCrafter commented 5 months ago

Oh, hello there @ferriarnus. I just wanna report the same thing on your Reforgedplay mod, thinking that you might fix it on your own. This problem occurs on Fabric version too, so my hope slowly disappears :<

VladisCrafter commented 5 months ago

At least thanks for explanation

VladisCrafter commented 5 months ago

This needs a registry sync to fix it (which is easier said then done).

Isn't there a way to just change how Replay mod saves block info? So at least new replays won't have that weak spot, @ferriarnus?

Su5eD commented 5 months ago

Duplicate of #833

jimmytimmy65 commented 4 months ago

I fixed it. You just need to make a new world and copy the data from old to new, only the folders not the level.dat