Sinytra / Connector

A compatibility layer that allows running Fabric mods on MinecraftForge
https://sinytra.org/docs/connector
MIT License
453 stars 16 forks source link

[1.20.1] Create: Railways Navigator + Seamless Loading Screen -> YACL mixin inject failure and startup crash #1191

Open Alexander3847575 opened 2 days ago

Alexander3847575 commented 2 days ago

Mod Name

Create: Railways Navigator (mcdragonlib), Seamless Loading Screen

Mod Homepage

https://github.com/MisterJulsen/MC-DragonLib2/

Minecraft version

1.20.1

Describe the bug

When attempting to boot with Create Railways Navigator, Seamless Loading Screen and Sinytra Connector, the mixin from YACL on ContainerEventHandler fails to apply and crashes pre-modload.

Steps to reproduce

When the following mods are installed, the game crashes on startup.

Mods used to replicate:

.connector/ folder was cleared before verification.

Logs

https://mclo.gs/rPueP6C

Additional context

⚠️ This issue ONLY occurs when ALL mods are present. No Fabric mods or YACL need to be installed for this to occur. Tested combinations of:

all booted properly.

Environment details:

Please let me know if any further information or other action is required, and if I should post this to the relevant mod repos.

Su5eD commented 2 days ago

Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/client/gui/components/events/ContainerEventHandler::modifyFocusCandidates with priority 1000 cannot inject into net/minecraft/client/gui/components/events/ContainerEventHandler::m264486(Lnet/minecraft/client/gui/navigation/ScreenRectangle;Lnet/minecraft/client/gui/navigation/ScreenDirection;Lnet/minecraft/client/gui/components/events/GuiEventListener;Lnet/minecraft/client/gui/navigation/FocusNavigationEvent;)Lnet/minecraft/client/gui/ComponentPath; merged by de.mrjulsen.mcdragonlib.mixin.ContainerEventHandlerMixin with priority 1000 [ -> redirect$zkh000$yet_another_config_lib_v3$modifyFocusCandidates(Lnet/minecraft/client/gui/components/events/ContainerEventHandler;Lnet/minecraft/client/gui/navigation/ScreenRectangle;Lnet/minecraft/client/gui/navigation/ScreenDirection;Lnet/minecraft/client/gui/components/events/GuiEventListener;Lnet/minecraft/client/gui/navigation/FocusNavigationEvent;)Ljava/util/List; -> Prepare]

Does this occur without Connector installed? According to the log, a conflict occurs between mods YACL and mcdragonlib.

Alexander3847575 commented 1 day ago

It does not, weirdly enough. mcdragonlib is an internal library in Railways Navigator, and I'm not sure where YACL is coming from. You can see my tested mod combinations under the Additional Context section; all done in the provided environment. As stated, the issue only occurs with all three mods present.