Sinytra / Connector

A compatibility layer that allows running Fabric mods on NeoForge
https://sinytra.org/docs/connector
MIT License
531 stars 23 forks source link

BetterEnd End stone variants, trees, and other plants aren't generating in the End #1331

Open starrysais opened 3 months ago

starrysais commented 3 months ago

Mod Name

Better End

Mod Homepage

https://modrinth.com/mod/betterend

Minecraft version

1.21.1

Describe the bug

The end stone variants don't generate when loading in new chunks in the end, which causes most of the modded plants to not generate. Blocks that have some sort of covering (like crystal moss) spawn somewhat normally. The ice starfield biomes are also generating normally, whereas in the fabric version they haven't for me.

Steps to reproduce

  1. Playing on 1.21
  2. Download BetterEnd and its dependencies
  3. Enter the end image image

Logs

https://pastebin.com/LU4tm25A

Additional context

No response

sweetbabyj3 commented 3 months ago

I recently had the same issue where better nether/end surface rules were broken and would not generate better X Grass blocks. It ended up being the mod Cyanide causing the issue. Not sure if this helps.

Cixon commented 3 months ago

Hey @Su5eD , I could of sworn this was temporally resolved with a data pack before, right? An older1.20.1 version of sinytra connector had the same issue.. interesting.

cleverruse commented 2 months ago

I am also having this issue. I noted that loot is only generating in End Cities, not in any custom structures. ln the pictures posted by @starrysais the sky box doesn't load either which Is also something I've been trying to solve. I've been at it for several hours and haven't found a solution.

It seems likely there is a problem with BetterEnd terrain generation (probably their custom sky as well) and Sinytra Connector. Other skyboxes work fine using FabricSkyBoxes and Interop. Not using Cyanide as reported by @sweetbabyj3. Makes me want to check out BetterNether as well.

End City Chest Loot Screenshot 2024-09-08 174832

Betterend Structure Loot Screenshot 2024-09-08 175001

Distant horizons wanting to show things working, but not as I move closer Screenshot 2024-09-08 175122 Screenshot 2024-09-08 175136 Screenshot 2024-09-08 175147

Cixon commented 2 weeks ago

I found a temporary fix. We just need help from a experienced data-pack maker

Image

A temporary fixed I made is forcing in the appropriate surface layer block using Minecraft's configured_feature via datapack like the Chorus Forest image above. Issue is, using the type minecraft:disk works as u can see but only covers a small area. The purple blobs (Chorus Nylium) replaces anything that's end_stone but again, does not cover the whole biome.

If someone can figure out how to successfully replace all end_stone with the appropriate biome block for the surface layer of each biome using configured_feature and placed_feature, all the foilage and trees will spawn like the example above.

Cixon commented 2 weeks ago

Give this a shot. It's not perfect but works.

cixonx_ugly_fast_fix.zip