search

Sinytra / Connector

A compatibility layer that allows running Fabric mods on NeoForge
https://sinytra.org/docs/connector
MIT License
532 stars 23 forks source link

Big Globe freezes worldgen at 18% #1429

Open cwielder opened 2 months ago

cwielder commented 2 months ago

Mod Name

Big Globe

Mod Homepage

https://modrinth.com/mod/big-globe

Minecraft version

1.21.1

Describe the bug

Creating a world with the Big Globe world type gets stuck at 18%

Steps to reproduce

  1. Install Big Globe
  2. Create a new world

Logs

https://mclo.gs/ITcB7KO

Additional context

No response

Builderb0y commented 2 months ago

Hi, developer of Big Globe here. This issue is, as far as I can tell, a mixin conflict into the class known by yarn mappings as MobSpawnerLogic. The purpose of my mixin is to allow some spawners to spawn lightning bolts whenever they spawn another entity. The mixin can be found here. I assume neoforge changes this class in a way that my mixin is not expecting. I have a config file that allows users to disable non-essential mixins in the event of conflicts like these, and disabling this mixin there seems to fix the problem for everyone who's tested it so far. I would like a better out-of-the-box solution for users though. Would you recommend checking if connector is installed via FabricLoader.getInstance().isModLoaded("connector") and disabling the mixin unconditionally in this case? Or is there a better option?

Builderb0y commented 1 month ago

Due to lack of response, I've gone ahead and disabled this mixin unconditionally if connector is detected. This should result in better compatibility with connector out-of-the-box for end users. Feel free to let me know if there's a better solution in the future.