Sinytra / Connector

A compatibility layer that allows running Fabric mods on NeoForge
https://sinytra.org/docs/connector
MIT License
531 stars 23 forks source link

Corrupted Create blocks' behavior on Replay recordings #833

Closed VladisCrafter closed 9 months ago

VladisCrafter commented 9 months ago

Mod Name

Create, Replay mod, Create add-ons

Mod Homepage

https://www.curseforge.com/minecraft/mc-mods/create, https://www.curseforge.com/minecraft/mc-mods/replay-mod-fabric-and-forge

Minecraft version

1.20.1

Describe the bug

When adding certain add-ons to the game and recording a replay, on watching it Create's blocks are corruptedly replaced by other random block(states)

Steps to reproduce

Record with Replay mod only - everything fine. Record with one extra add-on - cursed things.

Logs

In "Additional context"

Additional context

Create only: 2024-02-13_22 10 21 logs; Create and Copycats+: 2024-02-13_22 08 26 logs; Create and Design n Decor: 2024-02-13_22 06 25 logs; Create and Steam'n'Rails: 2024-02-13_22 04 16 logs.

VladisCrafter commented 9 months ago

The reason might actually be me entering the world with updated mods list, which somehow corrupts the NBT data of every non-vanilla(ish?) block. I'll try to record a world with constant modlist and see the results soon...

VladisCrafter commented 9 months ago

The problem was solved!

Due to some testing, of course.

The biggest thanks goes to @mxnmnm*, because THIS was his (their) comment on my issue in Sinytra's Discord server:

image

Well, test if this is true was a brilliant idea.

Created a fresh world with many of add-ons metioned in my issue. Recorded - everything fine! Added another, tiny add-on - shlt happened.

Created another fresh world with this "naughty" add-on included - EVERYTHING IS STILL FINE!

Meaning that all Replay mod needs in oreder to record properly is just a constant modlist for the world!

*Discord username used. Lmk if you know his (their) GitHub username, I'll replace it with the right one!

VladisCrafter commented 9 months ago

Also note, that only the mods that add new blocks/items are actually causing the corruption. You can add client-side mods safely :D

TheHaskBit commented 1 month ago

it turns out that you can delete the "FML" parameter in level.dat and the replay mod will show the replays correctly. personally, it helped me and didn't break the world (I'm not sure exactly, make a backup)

VladisCrafter commented 1 month ago

If only you told me it 7 months ago, @TheHaskBit... 😅