Sinytra / ForgifiedFabricAPI

Fabric API implemented on top of NeoForge
https://sinytra.org/docs
Apache License 2.0
107 stars 13 forks source link

Exception while adding particle #13

Closed KirboSoftware closed 1 year ago

KirboSoftware commented 1 year ago

Describe the bug

Crashes upon wandering the world

Steps to reproduce

  1. Run a client with just Forgified Fabric Api
  2. Create a world
  3. Wander around
  4. Crash

Logs

https://pastebin.com/A1QAdA4J

Additional context

This is soley with FFA, I tried running it with your other mod connector as well, but experienced the same issue sadly and wanted to pin the issue

Su5eD commented 1 year ago

From a similar issue on Connector's repo:

Seems to be caused by Forge adding a new tint hook which removes the call to BlockState#isOf, breaking our mixin. NeoForge seems to have applied the commit, too.

My plan is to cap the FFAPI Forge version range on 47.1.3, which has become the "status quo" version mods are staying on after the Forge/Neo split. It's likely the best way to maintain compatibility until the next mc version.

KirboSoftware commented 1 year ago

Alright thanks for notifying. I will test on that forge version and see if it still gives issues

Su5eD commented 1 year ago

Released FFAPI 0.86.1+1.8.1+1.20.1 which no longer crashes on never Forge versions, allowing FML to show the loading error screen with the version range mismatch.