search

Sinytra / ForgifiedFabricAPI

Fabric API implemented on top of NeoForge
https://sinytra.org/docs
Apache License 2.0
107 stars 13 forks source link

Smooth lighting seems broken with FFAPI, unlike FAPI #31

Closed Lolothepro closed 11 months ago

Lolothepro commented 1 year ago

Describe the bug

Indigo's fix for bug MC-197497 may be partially broken

Steps to reproduce

Go to a world with the "-465591111666617428" generation seed Go here: /execute in minecraft:overworld run tp @s 1732.17 -13.58 -463.76 -32.13 64.95

Fabric API: 2023-08-26_13 57 25

Forgified Fabric API: 2023-08-26_13 54 11

Logs

No response

Additional context

No response

Su5eD commented 1 year ago

Looks to happen on plain Forge, too.

Lolothepro commented 1 year ago

caused by https://github.com/Sinytra/ForgifiedFabricAPI/commit/690539c41b915d24dbcebb3810b4b10a6c127969

Su5eD commented 1 year ago

Yeah I remember indigo being a significant compat problem for forge mods.

Lolothepro commented 1 year ago

Yeah I remember indigo being a significant compat problem for forge mods.

Why? (do you have any examples?)

Su5eD commented 11 months ago

I've thought about this, and since the bug comes from vanilla, it should be fixed by mojang or forge. FFAPI's renderer does not override forge's one to prevent mod compat issues, and trying to fix issues by mixing into forge might come with unwanted side effects.