search

Sinytra / ForgifiedFabricAPI

Fabric API implemented on top of NeoForge
https://sinytra.org/docs
Apache License 2.0
107 stars 13 forks source link

Server crashes at startup #6

Closed Foxydre1 closed 1 year ago

Foxydre1 commented 1 year ago

Describe the bug

Server crashes at startup

Steps to reproduce

Launch the server with forge 47.1.3 in 1.20.1

Logs

https://pastebin.com/apf1PB1D

Additional context

Hello, We have a problem when adding ForgifiedFabricAPI to the server.

This seems to be linked to a compatibility problem with the waystone mod, which causes the server to crash on startup.

We are on version forge 47.1.3 in 1.20.1.

Thanks a lot!

Su5eD commented 1 year ago

By the looks of it, Balm makes a naughty move by registering creative tabs inside the deferred register value getter. Vanilla itself has a check for duplicate registry entries, but it only triggers in minecraft dev environments.

Our solution is pretty simple - ignoring duplicate ID checks for non-custom registries. In the Forgified FAPI, these should be handled by Forge / Vanilla. We should care about duplicate entries in custom registries we control.