SionBayliss / PIRATE

A toolbox for pangenome analysis and threshold evaluation.
GNU General Public License v3.0
89 stars 29 forks source link

Added to Brew pkg manager #21

Closed tseemann closed 4 years ago

tseemann commented 4 years ago

https://github.com/brewsci/homebrew-bio/pull/761

brew install brewsci/bio/pirate
tseemann commented 4 years ago
 - ERROR: could not make working directory in /usr/local/Cellar/pirate/1.0/libexec/bin/../scripts//../test/PIRATE/

Did you push #16 ? And use File::Temp->tempdir() ?

SionBayliss commented 4 years ago

Thanks! Yeah it is pushed to master. Odd. Is it pointed at the release version? I can make a new release with recent bugfixes if that is the issue.

tseemann commented 4 years ago

Brew can only use release versions (or tags). You can make a tag without making a release

git checkout master
git tag v1.0.1
git push --tags
SionBayliss commented 4 years ago

The new release included bug fixes and will (hopefully) be compatible with brew (v1.0.1)

tseemann commented 4 years ago
==> /usr/local/Cellar/pirate/1.0.1/bin/PIRATE --version 2>&1
==> /usr/local/Cellar/pirate/1.0.1/bin/PIRATE --help 2>&1
==> /usr/local/Cellar/pirate/1.0.1/bin/PIRATE --check
 - ERROR: could not make working directory in /usr/local/Cellar/pirate/1.0.1/libexec/bin/../scripts//../test/PIRATE/
Error: brewsci/bio/pirate: failed

Still getting the issue on MacOS.

SionBayliss commented 4 years ago

My bad. I missed a line. The newest tag (1.0.2) shouldn't create any files in PIRATE/test/.

SionBayliss commented 4 years ago

Sorry, I didn't mean to close this.

tseemann commented 4 years ago

Ok, it now works! your changes fixed all the issues with brew.