search

SionBayliss / PIRATE

A toolbox for pangenome analysis and threshold evaluation.
GNU General Public License v3.0
89 stars 29 forks source link

Replace mkdir with File::Path make_path #22

Closed tseemann closed 4 years ago

tseemann commented 4 years ago

https://perldoc.perl.org/File/Path.html#SYNOPSIS

Doing backquotes mkdir is not that safe.

SionBayliss commented 4 years ago

How about mkdir (https://perldoc.perl.org/functions/mkdir.html)?

tseemann commented 4 years ago

Yes that inbuilt will work too, and is better than using system. But make_path will work even if the folder already exists too. (like mkdir -p) It's a core module so adds no deps.

The remove_tree is a good cleanup function too.

SionBayliss commented 4 years ago

Cheers, I will standardise the scripts.

SionBayliss commented 4 years ago

Standardised on master branch release v1.0.1