search

Siphalor / ModsOfTheWorld

A mod to end the Minecraft rebranding bonanza
Creative Commons Zero v1.0 Universal
1 stars 2 forks source link

Mod logo containing capital letters in its filename causes ModsOfTheWorld not to show the mod logo + splash #4

Open NeRdTheNed opened 4 years ago

NeRdTheNed commented 4 years ago

...because they have capital letters in the file that Mods of the World tries to load, and identifiers can't have capital letters :)

Sample crash log.

Siphalor commented 4 years ago

Can you try if this loads the file correctly (and please then also tell what OS you use :) ) At least it won't crash anymore when mods put some unusual stuff in their icon path.

NeRdTheNed commented 4 years ago

From my testing, this bug was OS agnostic, as the crash seemed to be triggered by creating an Identifier for a mod icon with a capital letter in the file name (due to not being allowed to have a capital letter in an Identifier). I've now tested version 1.0.7 both on Windows 10 and MacOS Mojave (10.14.6), which causes a crash with Repurposed Structures.

The fix in version 1.0.8 works, and the game doesn’t crash! However, Repurposed Structures fails to show up in the changing logos, with no log output to indicate a failure. From my testing, this should be reproducible on Windows 10 or MacOS. However, this is much better than just crashing.

For a potential fix, I'd suggest looking into how Mod Menu loads mod icons, as it is able to display the logo of Repurposed Structures through using a NativeImage.