search

Siphalor / mouse-wheelie

"Small" Minecraft mod focusing on inventory utilities, like scrolling, sorting and auto refilling of items
https://modrinth.com/mod/mouse-wheelie
Apache License 2.0
113 stars 41 forks source link

[feature request] Better refill configurability #15

Open Arcensoth opened 5 years ago

Arcensoth commented 5 years ago

Version 1.2.2+1.14.2 (latest) Describe the bug Auto-refill uses different block type if none of the used block type remain. (e.g. running out of stone will auto-fill with logs; placing a shulker box will auto-refill the slot with crafting tables or whatever else is in the inventory.)

To Reproduce

  1. Place the last block of a type in your inventory, with some of another block type remaining.
  2. The empty slot will be filled with the other type of block.

Expected behavior Expected the slot to remain empty instead of being filled with a different type of block. In cases where the item/block max stack is 1 (e.g. shulker box), expected the slot to remain empty as well. However this behaviour may be desirable in circumstances so the ideal solution might be to make it configurable.

Log N/A

Additional context Suggested change is to add add configs for "auto-fill with other item/block types" as well as "auto-fill unstackable items/blocks" which would allow users to choose the behaviour they prefer.

Siphalor commented 5 years ago

I think I'll implement this as config options and consider this as "enhancement".

Siphalor commented 5 years ago

I implemented a more detailed configuration for this. If you want it not to refill with other blocks you may want to disable the following refill rules: Any block, blocks with similar functionality and refill by item groups.

tobe-continued commented 5 years ago

I've the same error, and your mod create config file in ".hjson" not ".json" maybe this is the problem. I've try to rename config file, but no change, your mod don't want config file :S

Siphalor commented 5 years ago

@Tobe-Continued

I've the same error, and your mod create config file in ".hjson" not ".json" maybe this is the problem. I've try to rename config file, but no change, your mod don't want config file :S

The hjson file extension is correct since those are a special kind of json files. This issue doesn't relate to config load problems but extending the configuration possibilities for auto-fill.

For issues with config files please open issues here.