search

Siphalor / mouse-wheelie

"Small" Minecraft mod focusing on inventory utilities, like scrolling, sorting and auto refilling of items
https://modrinth.com/mod/mouse-wheelie
Apache License 2.0
113 stars 41 forks source link

Update to Minecraft 1.19.4 #212

Closed ThexXTURBOXx closed 1 year ago

ThexXTURBOXx commented 1 year ago

This depends on https://github.com/Siphalor/tweed-api/pull/21 and after that is merged still needs a few more changes in order to work properly.

Fixes #208 Fixes #210

mk-pmb commented 1 year ago

I added a workflow to have the mod built on GitHub actions. That way we can work on error messages independent of our own computers' environments. The build currently seems to work, at least it produces a JAR file. What else can I do to help?

still needs a few more changes in order to work properly.

What failures do you encounter?

ThexXTURBOXx commented 1 year ago

@mk-pmb Thanks, but it's too early for a workflow right now. The problem is that tweed-api needs to be updated in order to be compatible with 1.19.4. As you can see in https://github.com/Siphalor/tweed-api/pull/21, I already created a PR for that, but it needs to be merged and published first so that tweed-api can be updated in this PR. If you try to use the current version of mouse-wheelie, it will crash during loading because of this

mk-pmb commented 1 year ago

Thanks! I'll try and circumvent the "needs to be merged" hurdle.

mk-pmb commented 1 year ago

I managed to build tweed on GitHub Actions. I managed to convince gradle to not use the outdated version by commenting-out the Siphalor maven repository.

The error message

Could not find de.siphalor.tweed4:tweed4-base-1.19:1.7.1+mc22w17a.

comes with a list of paths where Loom had searched for cached versions of that library, and I found a way to predict those paths based on the include(modApi( entries in build.gradle.

Which route seems more promising?

Update: Omitting the modApi lines just gives compiler errors about not finding some Config class. Seems like I need to inject my tweed-api. However, I cannot find the missing pom files anywhere in my build results. How do I build them?

Update: I should probably do as in the Maven FAQ "I have a jar that I want to put into my local repository." Let's see if I manage to get the arguments right.

Siphalor commented 1 year ago

Thanks for your work :)

I‌ rebased your branch on the unstable which contained the code for 1.19.3 and fixed a few small things, this is good to go now :+1: