Siphalor / mouse-wheelie

"Small" Minecraft mod focusing on inventory utilities, like scrolling, sorting and auto refilling of items
https://modrinth.com/mod/mouse-wheelie
Apache License 2.0
109 stars 42 forks source link

[Major Conflicts/Crash?] Crashes with other Mods #249

Open A5ho9999 opened 12 months ago

A5ho9999 commented 12 months ago

Version Fabric Version (0.14.22) 1.20.1 Mod Version: https://modrinth.com/mod/mouse-wheelie/version/1.13.0+mc1.20.1

Describe the bug I really don't know how to describe besides crashes with other Mods. Pretty much every Mod that as any kind of GUI/Screen or Client Rendering Features?

To Reproduce

  1. Install above version and use another Mod that has GUI's
    • To List some, Adorn, Architectury? Armourers Workshop, Let's Do Bakery, Let's do Beachparty, Recipe Book Is Pain, Chipped, Cooking for Blockheads
  2. Launch Game and wait.

Expected behavior Not crash lol

Log Important part: Caused by: [CIRCULAR REFERENCE: java.lang.ExceptionInInitializerError: Exception java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_507 failed [in thread "Render thread"]]

Full Log: https://gist.github.com/A5ho9999/97dcd181f0cdc33596c3480961d94248

Additional context Like 90% sure it's mouse wheelie has when removed there is no crash. I know issue isn't present in "mousewheelie-1.12.2+mc1.20.1.jar"

It could just also be a conflict with adorn since that's at the top of the list, but I don't know. This one is very confusing

Siphalor commented 12 months ago

The issue seems to be the mod "recipe-book-is-pain".

That mod seems to be trying to patch a mixin of Mouse Wheelie (?).

I'll try to do a closer analysis after work, but using MW 1.12 or removing that mod should be a workaround for now.

A5ho9999 commented 12 months ago

Yes removing recipe-book-is-pain did allow 1.13 to work.

melontini commented 11 months ago

Hi, RBIP dev here. This crash doesn't happen on 0.10.0, since this injector is marked as required = 0 in that version. While not required, this injector not applying causes recipe alternatives to not close on scrolling. (This should probably be PRd to MW itself).

There's also RBIP/DM specific logic for page scrolling, but I don't see this being implemented in MW 😅