Siphalor / nbt-crafting

A 1.15+ fabric Minecraft mod to enable nbt related recipe stuff
https://modrinth.com/mod/nbt-crafting
Apache License 2.0
49 stars 26 forks source link

[bug] Smelting recipes doesn't check for output slot #111

Closed ghost closed 2 years ago

ghost commented 2 years ago

Version 1.19 fabric

Describe the bug When there are two recipes with same input id and same output id present, the input item can be replaced interchangeably and it will produce the item output slot had.

To Reproduce

  1. Create two recipes with same output item id.
  2. Smelt it.
  3. Replace the input item from other recipe and see items still produce the same item output slot had.

Expected behavior I expected it not to output items like the output slot had.

Normal behavior изображение изображение

That's where the problem starts изображение изображение

My json files

Normal beef

{
  "type": "minecraft:smelting",
  "cookingtime": 200,
  "experience": 0.35,
  "ingredient": {
    "item": "minecraft:beef",
    "data": {
      "deny": {
          "CustomModelData": 1
      }
    }
},
  "result": {
  "item": "minecraft:cooked_beef"
  }
}

Custom meat

{
  "type": "minecraft:smelting",
  "cookingtime": 200,
  "experience": 0.35,
  "ingredient": {
    "item": "minecraft:beef",
    "data": {
      "require": {
          "CustomModelData": 1
      }
    }
},
  "result": {
  "item": "minecraft:cooked_beef",
    "data": {
      "CustomModelData": 1,
      "display": {
        "Name": "[{\"text\":\"Custom meat\",\"italic\":false}]"
      }
    }
  }
}