search

Siphalor / nbt-crafting

A 1.15+ fabric Minecraft mod to enable nbt related recipe stuff
https://modrinth.com/mod/nbt-crafting
Apache License 2.0
49 stars 26 forks source link

[bug] KubeJS incompatibility? #58

Open superon opened 3 years ago

superon commented 3 years ago

Version latest Describe the bug incompatibility

To Reproduce

  1. Use json to craft something that outputs an enchanted item.
  2. doesn't work

Expected behavior craft something that outputs an enchanted item.

Log no log

Additional context i hear it's an issue where this recipe doesn't work when kubejs is included bc nbtcrafting coremods vanilla. idk what that means, don't try to explain. just wondering if a future release can remedy this or if there's something i'm missing or possible another mod recommendation.

justastranger commented 3 years ago

The way KubeJS adds recipes completely side-steps NBT Crafting. This mod could provide a KubeJS plug-in or add its own crafting types (instead of taking over minecraft:shaped, provide nbtcrafting:shaped) in order to allow KubeJS to take advantage of nbt crafting. The latter would be the least amount of work, I imagine. KubeJS is already fully capable of creating and passing on NBT data for crafting recipes, just not capable of creating crafting recipes that can actually take advantage of it.

Mari023 commented 3 years ago

~~Would be really nice if this could be fixed, as I have to rely on nbtcrafting for some of my items. currently, when kubejs is installed, the recipe gets the nbt completely striped, rendering the crafted item useless.~~ I replaced NBTCrafting with my own recipe type. It would be still nice if this bug were to be fixed