Compatibility Request - Githubissues

DanShu15 commented 4 years ago

I've outlined the issue on Sandwichables Git here https://github.com/FoundationGames/Sandwichable/issues/26

Basically different sandwiches count as the same food and seem to take longer to eat than the previous one, just like eating the same food.

I was hoping compatibility could be achieved :) If this is something I can do for my server with datapacks I'm totally down to go that route as well, but built in compatibility would be ideal :) If you could point me in the right direction I can make it happen :)

Thanks!

Edit- LMFAO nobody listened to me and kept eating the sandwiches because they're such great food. Now they can't eat anything that was used in making the sandwiches they ate either, like normal cooked chicken LOL Might upgrade that one from feature request to a bug

Console log spam: https://pastebin.com/84H5YARy

DanShu15 commented 4 years ago

What about a blacklist for foods that aren't compatible to be ignored and work like normal foods? sandwichable:sandwich, minecraft:golden_apple etc

Some mods add healing items that I think count as food (I don't have any atm) but it might be worth having implemented

Siphalor commented 4 years ago

lol that edit :laughing:

You wouldn't believe but I am the author of squeek502/SpiceOfLife#151 ^^

I designed this mod so that it can be extended to support nbt dependencies but never got that far.

Currently I have that much time for modding and I prioritize other mods that have more users.

I only updated to recent MC versions because I got pushed :)

Maybe I'm gonna revisit this issue if I've got more time beginning in two weeks or so.

PS: You can join the discord server to see when I'm ready again if you like to ;)

DanShu15 commented 4 years ago

Any other time I'd clear their player data but I did try to warn them ;) They've recovered since then LOL No worries at all on the update/feature request. When you get around to spice of fabric for 1.16 we'll be bringing it back for sure :) Stuff is about to get hectic starting tomorrow ;) Best of luck on your exams! I'll keep an eye on your discord for more info :)

Siphalor commented 3 years ago

Ok, I'm now actually onto implementing some more complex stuff to SoF like grouping specific foods together with custom formulas and stuff. So I've got a question on what you think would be best:

Keep those configs solely somewhere in the mod config directory (like Spice of Life does it iirc)
Have those food groups as a new data type solely in datapacks
Or both (which is the more complicated solution)

The config directory is always good for modpack creators but there are mods that give them the ability to define global datapacks. Datapacks would be really good for mods because Sandwichable could define it's nbt stuff on it's own and could still easily be overriden. It still means less comfort for modpack authors. Doing both is just really annoying for myself :)

TobiPeterG commented 3 years ago

Ok, I'm now actually onto implementing some more complex stuff to SoF like grouping specific foods together with custom formulas and stuff. So I've got a question on what you think would be best:
* Keep those configs solely somewhere in the mod config directory (like Spice of Life does it iirc)

* Have those food groups as a new data type solely in datapacks

* Or both (which is the more complicated solution)
The config directory is always good for modpack creators but there are mods that give them the ability to define global datapacks. Datapacks would be really good for mods because Sandwichable could define it's nbt stuff on it's own and could still easily be overriden. It still means less comfort for modpack authors. Doing both is just really annoying for myself :)

hmm well, since nobody answered, I will now :D

I guess the config option is the best one currently, as users have pretty easy access to it. Though, implementing both would of course be the optimal solution here

DanShu15 commented 3 years ago

Sorry, I didn't see this until your reply. I'm personally a huge fan of datapacks for customizing things, but a config option would do just fine 🙂

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Tobi_Peter @.> Sent: Monday, August 30, 2021 11:42:11 AM To: Siphalor/spiceoffabric @.> Cc: DanShu15 @.>; Author @.> Subject: Re: [Siphalor/spiceoffabric] Compatibility Request (#6)

Ok, I'm now actually onto implementing some more complex stuff to SoF like grouping specific foods together with custom formulas and stuff. So I've got a question on what you think would be best:

Keep those configs solely somewhere in the mod config directory (like Spice of Life does it iirc)
Have those food groups as a new data type solely in datapacks
Or both (which is the more complicated solution)

The config directory is always good for modpack creators but there are mods that give them the ability to define global datapacks. Datapacks would be really good for mods because Sandwichable could define it's nbt stuff on it's own and could still easily be overriden. It still means less comfort for modpack authors. Doing both is just really annoying for myself :)

hmm well, since nobody answered, I will now :D

I guess the config option is the best one currently, as users have pretty easy access to it. Though, implementing both would of course be the optimal solution here

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Siphalor/spiceoffabric/issues/6#issuecomment-908549207, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJSXVQLY56ERIQ7K2RRG3Z3T7O7HHANCNFSM4N5XE7IQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Siphalor / spiceoffabric

Compatibility Request #6