SirBlobman / CombatLogX

A modular Spigot plugin that prevents players from logging out during combat and has many expansions for extra features.
https://www.spigotmc.org/resources/31689/
GNU General Public License v3.0
154 stars 52 forks source link

Persistent Data container not being inherited for citizens #713

Open LupusVirtute opened 1 year ago

LupusVirtute commented 1 year ago

Server Implementation

Paper

Server Version

1.19.4

Describe the bug

PersistentDataContainer is not inherited for CitizensCompatibility

Reproduction Steps

  1. Set value in persistent data container for player
  2. Attack player
  3. Quit as player being attacked
  4. Persistent data container is not retained

Expected behaviour

Persistent data container is preserved

Screenshots / Videos

With logging out during combat: image Without: image

latest log file (if applicable)

No response

CombatLogX Version

[01:50:54 INFO]: Java Version: 20.0.1
[01:50:54 INFO]: Java Vendor: Eclipse Adoptium [01:50:54 INFO]: Java URL: N/A
[01:50:54 INFO]: Server Version: git-Paper-550 (MC: 1.19.4) [01:50:54 INFO]: Bukkit Version: 1.19.4-R0.1-SNAPSHOT
[01:50:54 INFO]: Minecraft Version: 1.19.4
[01:50:54 INFO]: NMS Version: 1_19_R3
[01:50:54 INFO]: Dependency Information:
[01:50:54 INFO]: - AngelChest (not installed)
[01:50:54 INFO]: - ASkyBlock (not installed)
[01:50:54 INFO]: - BentoBox (not installed)
[01:50:54 INFO]: - Citizens v2.0.32-SNAPSHOT (build 3200) [01:50:54 INFO]: - CMI (not installed)
[01:50:54 INFO]: - CrackShot (not installed)
[01:50:54 INFO]: - CrashClaim (not installed)
[01:50:54 INFO]: - Essentials (not installed) [01:50:54 INFO]: - FabledSkyBlock (not installed) [01:50:54 INFO]: - FeatherBoard (not installed) [01:50:54 INFO]: - FlagWar (not installed) [01:50:54 INFO]: - GriefDefender (not installed) [01:50:54 INFO]: - GriefPrevention (not installed) [01:50:54 INFO]: - HuskHomes (not installed) [01:50:54 INFO]: - HuskSync (not installed) [01:50:54 INFO]: - HuskTowns (not installed) [01:50:54 INFO]: - iDisguise (not installed) [01:50:54 INFO]: - IridiumSkyblock (not installed) [01:50:54 INFO]: - Kingdoms (not installed) [01:50:54 INFO]: - Konquest (not installed) [01:50:54 INFO]: - Lands (not installed) [01:50:54 INFO]: - LibsDisguises (not installed) [01:50:54 INFO]: - MarriageMaster (not installed) [01:50:54 INFO]: - MythicMobs v5.2.6-0819d467 [01:50:54 INFO]: - PlaceholderAPI v2.11.3 [01:50:54 INFO]: - PlayerParticles (not installed) [01:50:54 INFO]: - PreciousStones (not installed) [01:50:54 INFO]: - PremiumVanish (not installed) [01:50:54 INFO]: - ProtectionStones (not installed) [01:50:54 INFO]: - ProtocolLib v5.0.0 [01:50:54 INFO]: - RedProtect (not installed) [01:50:54 INFO]: - Residence (not installed) [01:50:54 INFO]: - Sentinel (not installed) [01:50:54 INFO]: - SuperiorSkyblock2 (not installed) [01:50:54 INFO]: - SuperVanish (not installed) [01:50:54 INFO]: - Towny (not installed) [01:50:54 INFO]: - UltimateClaims (not installed) [01:50:54 INFO]: - uSkyBlock (not installed) [01:50:54 INFO]: - VanishNoPacket (not installed) [01:50:54 INFO]: - WorldGuard v7.0.8+33cdb4a [01:50:54 INFO]: - ViaVersion (not installed) [01:50:54 INFO]: - BlueSlimeCore v2.9.4.377 [01:50:54 INFO]: CombatLogX by SirBlobman [01:50:54 INFO]: Local Version: 11.4.0.1.1193 [01:50:54 INFO]: Remote Version: 11.4.0.1.1193 [01:50:54 INFO]: Enabled Expansions (9): [01:50:54 INFO]: - Action Bar v17.3 [01:50:54 INFO]: - Boss Bar v17.1 [01:50:54 INFO]: - Cheat Prevention v17.6 [01:50:54 INFO]: - Citizens Compatibility v17.9 [01:50:54 INFO]: - PlaceholderAPI Compatibility v17.1 [01:50:54 INFO]: - WorldGuard Compatibility v17.2 [01:50:54 INFO]: - Glowing v17.0 [01:50:54 INFO]: - Logger v17.2 [01:50:54 INFO]: - Scoreboard v17.1

Anything else?

Some plugins use persistent data container for storing information about current player stats it can go haywire