search

SirBlobman / CombatLogX

A modular Spigot plugin that prevents players from logging out during combat and has many expansions for extra features.
https://www.spigotmc.org/resources/31689/
GNU General Public License v3.0
154 stars 52 forks source link

Citizens Extension not working correctly. #844

Open h14turkiye opened 2 months ago

h14turkiye commented 2 months ago

Server Implementation

Paper

Server Version

1.21

Describe the bug

Inventory clears, double npc spawns, can't really understand the behaviour.

Reproduction Steps

  1. Player b has some stuff inside his inventory.
  2. Tag player b
  3. Player b disconnects and sometimes leaves behind 2 npcs
  4. Don't kill the npc of player b and (let it disappear||player b joins before npc disappears)
  5. Player's b inventory is cleaned.

Expected behaviour

  1. Player b disconnects and leaves behind a single npc
  2. Player's b inventory stays the same.

Screenshots / Videos

No response

latest log file (if applicable)

No response

CombatLogX Version

v11.5.0.0.1242

Anything else?

No response

Olivoz commented 2 months ago

Please follow the issue template and provide the entire output from the /clx version command.

h14turkiye commented 2 months ago

clx version [10:52:55 INFO]: Java Version: 22.0.2 [10:52:55 INFO]: Java Vendor: Oracle Corporation [10:52:55 INFO]: Java URL: N/A [10:52:55 INFO]: Server Version: 1.21.1-11-9a82b86 (MC: 1.21.1) [10:52:55 INFO]: Bukkit Version: 1.21.1-R0.1-SNAPSHOT [10:52:55 INFO]: Minecraft Version: 1.21.1 [10:52:55 INFO]: NMS Version: Unsupported [10:52:55 INFO]: Dependency Information: [10:52:55 INFO]: - AngelChest (not installed) [10:52:55 INFO]: - ASkyBlock (not installed) [10:52:55 INFO]: - BentoBox (not installed) [10:52:55 INFO]: - Citizens v2.0.35-SNAPSHOT (build 3521) [10:52:55 INFO]: - CMI (not installed) [10:52:55 INFO]: - CrackShot (not installed) [10:52:55 INFO]: - CrashClaim (not installed) [10:52:55 INFO]: - Essentials v2.21.0-dev+110-f1a5caf [10:52:55 INFO]: - FabledSkyBlock (not installed) [10:52:55 INFO]: - FeatherBoard (not installed) [10:52:55 INFO]: - FlagWar (not installed) [10:52:55 INFO]: - GriefDefender (not installed) [10:52:55 INFO]: - GriefPrevention (not installed) [10:52:55 INFO]: - HuskHomes (not installed) [10:52:55 INFO]: - HuskSync (not installed) [10:52:55 INFO]: - HuskTowns (not installed) [10:52:55 INFO]: - iDisguise (not installed) [10:52:55 INFO]: - IridiumSkyblock (not installed) [10:52:55 INFO]: - Kingdoms (not installed) [10:52:55 INFO]: - Konquest (not installed) [10:52:55 INFO]: - Lands (not installed) [10:52:55 INFO]: - LibsDisguises (not installed) [10:52:55 INFO]: - MarriageMaster (not installed) [10:52:55 INFO]: - MCPets (not installed) [10:52:55 INFO]: - MythicMobs (not installed) [10:52:55 INFO]: - PlaceholderAPI v2.11.6 [10:52:55 INFO]: - PlayerParticles (not installed) [10:52:55 INFO]: - PreciousStones (not installed) [10:52:55 INFO]: - PremiumVanish (not installed) [10:52:55 INFO]: - ProtectionStones (not installed) [10:52:55 INFO]: - ProtocolLib v5.3.0-SNAPSHOT-726 [10:52:55 INFO]: - RedProtect (not installed) [10:52:55 INFO]: - Residence (not installed) [10:52:55 INFO]: - Sentinel (not installed) [10:52:55 INFO]: - SuperiorSkyblock2 (not installed) [10:52:55 INFO]: - SuperVanish (not installed) [10:52:55 INFO]: - Towny v0.100.3.0 [10:52:55 INFO]: - UltimateClaims (not installed) [10:52:55 INFO]: - uSkyBlock (not installed) [10:52:55 INFO]: - VanishNoPacket (not installed) [10:52:55 INFO]: - WorldGuard (not installed) [10:52:55 INFO]: - ViaVersion v5.0.3 [10:52:55 INFO]: - BlueSlimeCore v2.9.6.431 [10:52:55 INFO]: CombatLogX by SirBlobman [10:52:55 INFO]: Local Version: 11.5.0.0.1242 [10:52:55 INFO]: Remote Version: 11.5.0.0.1242 [10:52:55 INFO]: Enabled Expansions (6): [10:52:55 INFO]: - Boss Bar v17.1 [10:52:55 INFO]: - Cheat Prevention v17.7 [10:52:55 INFO]: - Citizens Compatibility v17.15 [10:52:55 INFO]: - Towny Compatibility v17.5 [10:52:55 INFO]: - Logger v17.3 [10:52:55 INFO]: - Scoreboard v17.1

h14turkiye commented 2 months ago

I think I understand the problem. It only happens if you are tagged and always-spawn-npc-on-quit is true. It somehow spawns 2 npcs, one holding items armor etc, one holding nothing. Perhaps prevent punish and quit executes same time?