search

SirBlobman / CooldownsX

A plugin that adds configurable cooldowns to items.
https://www.spigotmc.org/resources/41981/
3 stars 11 forks source link

Suggestion: Add support for brewing brews #30

Open TomLewis opened 1 year ago

TomLewis commented 1 year ago

Add support for Brews made in https://www.spigotmc.org/resources/brewery.3082/ It could be as simple as listing brewingIDs under the cooldown type.

exampleBrewing:
  cooldown: 30
  cooldown-type: POTION_THROW
  brewingIDs:
    - 123
    - 124
  amount: 2
  reset-amount: true
CarissaCoding commented 4 months ago

Hey @TomLewis,

Hope you're doing well! We're all in for adding support for Brewery's brews to our plugin. To make sure we nail the integration, could you shoot over the custom brewing jar file you're using to my email carissa.s.davis@gmail.com? It'll give us the lowdown on what we're working with and help us get this feature up and running smoothly. I think we should be able to directly integrate it for you if its urgent in a couple of days time.

Thanks a bunch for your help on this one. Looking forward to diving in and making this happen and sorry for the delay!

Cheers,

Carissa

TomLewis commented 4 months ago

Im not using a custom brewing jar! im using the one from the Spigot page! This is fantastic you are going to add cooldowns, it will be much appriciated!

CarissaCoding commented 4 months ago

Im not using a custom brewing jar! im using the one from the Spigot page! This is fantastic you are going to add cooldowns, it will be much appriciated!

Hi @TomLewis!

Sorry I did not explain myself correctly earlier, I don't mean to say you're using a modified version of the plugin, thats my bad! I meant to say if you could send the brewery pluggin with however you've customized it (changed milk strength effects, added custom recipes etc) as it would be really helpful to troubleshoot it and find any bugs it might have, and we'll work on releasing a public version with this sometime in the future.

Thanks! Carissa

TomLewis commented 4 months ago

You'll be fine with the vanilla examples, all the additional brews created are just copies of the example brews teeaked!

SirBlobman commented 6 days ago

@TomLewis Apologies, didn't see this. Not sure why that account is trying to send messages on my behalf as I do not know them personally. I'll look into adding support in a future update.