SirDiazo / AGExt

Action Groups Extended
13 stars 19 forks source link

AGX used to set/edit standard actions groups #5

Closed diomedea closed 10 years ago

diomedea commented 10 years ago

KSP only allows to set standard action groups (gear, brakes, lights, RCS, SAS....) in the editor. AGX instead allows to edit any of its action groups while in flight, and is a valuable tool to correct the actions associated, in particular while docking/undocking vessels. Would be great if AGX could deal also with those standard action groups like those were its own.

SirDiazo commented 10 years ago

I think this is partially implemented.

In flight mode, there should be an "Other" button now between the Auto-Hide and the Page numbers. Clicking that should allow you to edit Gear/Brake/Light/Abort actions in flight.

I added this back in version 1.15 and that was just before the save/load routine blew up so I kind of forgot about it.

RCS and SAS can not be edited this way due to KSP limitations. Those action groups run custom code to turn on and off RCS/SAS and I can not access that custom code so no integration with AGX.

This is not implemented in the editor yet, you must use KSP's default editor for now although I will be copying the Other button across sometime soon.

diomedea commented 10 years ago

Yes, found (now that you mentioned it) the "other" button, does what I wanted for those 4 actions. Will have to accept that no editing can be done about SAS and RCS until a solution is found (must say, RCS was really one group I wanted the chance to edit, at the moment I must double the control to another key with AGX for specific thrusters that I want to turn on/off, e.g. when deploying/recovering a probe from another vessel).

SirDiazo commented 10 years ago

I don't follow how enabling RCS thruster blocks on the RCS action group would do anything.

All RCS thrusters are "activated" when you tap R to enable the RCS system in that KSP will now send commands to them. Tapping R a second time "deactivates" all RCS thrusters as the RCS system is now off.

This activate/deactivate is hidden in KSP somewhere, RCS thrusters being assigned to the RCS Action Group do not affect this. (At least, that is what I remember from my tests, but those were a long time, and several patches ago.)

diomedea commented 10 years ago

My issue is exactly in that: "All RCS thrusters...". KSP by default assigns every block to the RCS group, though that is editable in VAB/SPH. However, I need to isolate specific groups that will come useful only after some stage in a mission, but not before. Most easy example is when I build a vessel carrying children vessels, I want to use only the RCS on the main vessel at first, so delete all RCS blocks of the children in the editor. But after they are detached, all RCS have to be usable. As I can't change the assignments in the RCS group in flight, I have to use other action groups for that. If it was possible to enable RCS group editing with AGX, I would instead use the RCS group with the freedom required.

SirDiazo commented 10 years ago

Oh, I see what you are trying to do now.

In my case, I would use the other action group to turn on/off the RCS blocks as that fits my playstyle better.

You want to be able to turn off RCS blocks directly without having to setup a second RCS group.

SirDiazo commented 10 years ago

Fully implemented as of version 1.20