SirEdvin / Turtlematic

ComputerCraft addon that makes turtle great again!
MIT License
11 stars 2 forks source link

Added mercantile automata cores #4

Closed grace5532 closed 1 year ago

grace5532 commented 1 year ago

Features implemented:

SirEdvin commented 1 year ago

Thanks for you code, sorry for delay with replay. I will review it next week

grace5532 commented 1 year ago

Oh no worries, I hope all is well. Let me know if there's anything you need when you're doing the review

SirEdvin commented 1 year ago

So, thanks for code, I am going to merge it. There are some things, that I would probably change:

SirEdvin commented 1 year ago

Oh, as usual, I changed a lot.

Trading will also work with wandering trader, will provide XP, you will have ability to hint trade that you want to make (there is can be several trades with emerald + book, for example) and something like this.

grace5532 commented 1 year ago

Your changes make sense, thanks for reviewing it! I don't remember why I thought it was a good idea to chose the trade automatically, but hinting is better. Thanks again!

SirEdvin commented 1 year ago

It will try to trade automatically, but if it founds several candidates, hint will reqbe be requested

SirEdvin commented 1 year ago

Btw, this feature is relesed in version 0.5.3 for both 1.18 and 1.19.2

SirEdvin commented 1 year ago

I will add documentation today or tommorow, but in general it look like this:

trade(hint?: int, direction?: Direction). Item to trade should be in selected slot and second item should be next to it if required.

Why this design? This decent to ComputerCraft craft function which I found pretty nice to use

SirEdvin commented 1 year ago

And documentation is also added

grace5532 commented 1 year ago

That makes sense, also, the documentation looks great, and allowing starbound cores to restock is a great idea! I’m sure you don’t need my approval, but still, this is very exciting