Closed grace5532 closed 1 year ago
Thanks for you code, sorry for delay with replay. I will review it next week
Oh no worries, I hope all is well. Let me know if there's anything you need when you're doing the review
So, thanks for code, I am going to merge it. There are some things, that I would probably change:
Oh, as usual, I changed a lot.
Trading will also work with wandering trader, will provide XP, you will have ability to hint trade that you want to make (there is can be several trades with emerald + book, for example) and something like this.
Your changes make sense, thanks for reviewing it! I don't remember why I thought it was a good idea to chose the trade automatically, but hinting is better. Thanks again!
It will try to trade automatically, but if it founds several candidates, hint will reqbe be requested
Btw, this feature is relesed in version 0.5.3 for both 1.18 and 1.19.2
I will add documentation today or tommorow, but in general it look like this:
trade(hint?: int, direction?: Direction)
. Item to trade should be in selected slot and second item should be next to it if required.
Why this design? This decent to ComputerCraft craft
function which I found pretty nice to use
And documentation is also added
That makes sense, also, the documentation looks great, and allowing starbound cores to restock is a great idea! I’m sure you don’t need my approval, but still, this is very exciting
Features implemented: