search

SirEdvin / UnlimitedPeripheralWorks

Extreme compact CC:R and CC:T mod that tries to make everything, that even possible a peripheral
MIT License
9 stars 3 forks source link

fix fluid tally in ME networks #5

Closed mblaze closed 1 year ago

mblaze commented 1 year ago

I've tested your mod today (mainly for the integration with AE2) and found out that the listing of fluids (tanks Lua function) in an ME network always returns an empty table. I prepared a fix and tested it in a simple scenario. It seems to work. What caused problems in your implementation is a missing items.add(data). For that reason I've refactored it to use a map so that similar mistake is not possible in the future.

mblaze commented 1 year ago

Now that I look at the repo I might have misunderstood the branching model. Do you always merge from 1.18 to 1.19? Might be worth putting some rules in the readme for future contributors.

SirEdvin commented 1 year ago

Yes, always. I hope I will to this to the end of week :)

mblaze commented 1 year ago

Ok, so we can close this PR and I will create one for 1.18 today in the evening.